Skip to content

Commit

Permalink
fix(compiler): set end location for incomplete elements (#9598)
Browse files Browse the repository at this point in the history
  • Loading branch information
gzzhanghao authored and yyx990803 committed Mar 1, 2019
1 parent 1574ade commit cbad54a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/compiler/parser/html-parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export function parseHTML (html, options) {
) {
options.warn(
`tag <${stack[i].tag}> has no matching end tag.`,
{ start: stack[i].start }
{ start: stack[i].start, end: stack[i].end }
)
}
if (options.end) {
Expand Down
3 changes: 2 additions & 1 deletion src/compiler/parser/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export function parse (
shouldDecodeNewlinesForHref: options.shouldDecodeNewlinesForHref,
shouldKeepComment: options.comments,
outputSourceRange: options.outputSourceRange,
start (tag, attrs, unary, start) {
start (tag, attrs, unary, start, end) {
// check namespace.
// inherit parent ns if there is one
const ns = (currentParent && currentParent.ns) || platformGetTagNamespace(tag)
Expand All @@ -229,6 +229,7 @@ export function parse (
if (process.env.NODE_ENV !== 'production') {
if (options.outputSourceRange) {
element.start = start
element.end = end
element.rawAttrsMap = element.attrsList.reduce((cumulated, attr) => {
cumulated[attr.name] = attr
return cumulated
Expand Down
5 changes: 5 additions & 0 deletions test/unit/modules/compiler/compiler-options.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ describe('compile options', () => {
expect(compiled.errors[0].end).toBe(17)
expect(compiled.errors[1].start).toBe(18)
expect(compiled.errors[1].end).toBe(29)

compiled = compile('<div><span></div>', { outputSourceRange: true })
expect(compiled.errors.length).toBe(1)
expect(compiled.errors[0].start).toBe(5)
expect(compiled.errors[0].end).toBe(11)
})

it('should collect source range for binding keys', () => {
Expand Down

0 comments on commit cbad54a

Please sign in to comment.