Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is attribute still present in the DOM after compilation #2666

Closed
GuillaumeLeclerc opened this issue Apr 13, 2016 · 3 comments · Fixed by #2672
Closed

is attribute still present in the DOM after compilation #2666

GuillaumeLeclerc opened this issue Apr 13, 2016 · 3 comments · Fixed by #2672

Comments

@GuillaumeLeclerc
Copy link

Vue.js version

1.0.21

Reproduction Link

I was not able to reproduce it in a jsfiddle. I can upload the whole thing to webpackbin if needed
https://github.com/GuillaumeLeclerc/vue-seo/blob/master/src/components/headDisplayer.vue

(When the component is used multiples times)

Steps to reproduce

Create multiple elements with a :is attribute.

What is Expected?

The :is attribute is removed from the markup after being compiled

What is actually happening?

All the :is attribute are visible in the dom (except for the first one)

<!-- This is working for the first one -->
<link rel="alternate" hreflang="fr" href="google.fr"> 
<!-- all the following have the is attribute displayed -->
<link rel="alternate" is="function VueComponent(options) { this._init(options) }" hreflang="de" href="google.fr"> 

Node the behavior is perfectly correct just the is attribute is displayed as a string.

Thank you

@yyx990803 yyx990803 added the bug label Apr 13, 2016
@yyx990803
Copy link
Member

Hmm, can't really tell much from the component alone, would prefer an actual repro.

@GuillaumeLeclerc
Copy link
Author

I'll make a proper repro then

@GuillaumeLeclerc
Copy link
Author

GuillaumeLeclerc commented Apr 15, 2016

Fixing the bug was actually way quicker than making a repro so I made a PR (#2672) that fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants