Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix v-bind.prop parse (fix #4432) #4435

Merged
merged 4 commits into from Dec 11, 2016
Merged

fix v-bind.prop parse (fix #4432) #4435

merged 4 commits into from Dec 11, 2016

Conversation

defcc
Copy link
Member

@defcc defcc commented Dec 10, 2016

fix #4432

posva
posva requested changes Dec 10, 2016
View reviewed changes
test/unit/features/directives/bind.spec.js
template: '<input :some.prop="some" :id="id">',
data: {
some: 'hello',
id: 'world'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the test case should use a null or false value and check that the id attribute is absent on the element

Copy link
Member Author

@defcc defcc Dec 10, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the test case

@posva
Copy link
Member

posva commented Dec 10, 2016

I can't believe the fix was that easy 😆
Good job again @defcc 👍

posva
posva approved these changes Dec 10, 2016
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the tests pass on CI, though 😆

@defcc
Copy link
Member Author

defcc commented Dec 10, 2016

For the test case, the id attribute is special, it reflects both with attribute and property.

@yyx990803 yyx990803 merged commit 183bd43 into vuejs:dev Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@defcc @posva @yyx990803