Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

Closed
m-schier opened this issue Mar 9, 2017 · 2 comments
Closed

Incompatible event modifiers on keypress between 2.2.2 and 2.2.1 #5146

m-schier opened this issue Mar 9, 2017 · 2 comments

Comments

@m-schier
Copy link

m-schier commented Mar 9, 2017

From version 2.2.2 to 2.2.1 it appears the logic for handling keypress events with a key-modifier and the prevent-modifier has changed.

In 2.2.1 an 'keypress.enter.prevent' would only prevent default action for the enter key, but in 2.2.2 it prevents every key.

I expected the behaviour to stay consistent with both releases, unless this change is intended.

Compare
2.2.1: https://jsfiddle.net/p4ay5v9c/2/
2.2.2: https://jsfiddle.net/z17jjxh6/1/

From my understanding the changelog for 2.2.2 does not list this change, so I reckon it is not intentional.

@posva
Copy link
Member

posva commented Mar 9, 2017

The change is not intentional, thanks for pointing it out. I'll take a look

Kingwl pushed a commit to Kingwl/vue that referenced this issue Mar 9, 2017
yyx990803 pushed a commit that referenced this issue Mar 10, 2017
* fix wrong order of generate modifier code

* add unit test of #5146

* Update events.js
@yyx990803
Copy link
Member

Fixed via #5147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants