Check enterToClass/leaveToClass existence before adding it #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When leave a tab in Chrome, timer (setInterval) seems not be throttled but requestAnimationFrame is. So that will result in vue keeping enqueue requestAnimationFrame tasks, and all of them will be executed when user comes back to the tab. (That's why I'm using |
yyx990803
requested changes
Jun 30, 2017
| @@ -68,6 +68,10 @@ export function nextFrame (fn: Function) { | |||
| }) | |||
| } | |||
|
|
|||
| export function hasTransitionClass (el: any, cls: string) { | |||
There was a problem hiding this comment.
I think it's better to just check this directly inside addTransitionClass.
There was a problem hiding this comment.
Put hasTransitionClass check only inside nextFrame is trying to avoid unnecessary checking. It fair to put it inside addTransitionClass.
yyx990803
approved these changes
Jun 30, 2017
|
thanks👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5800
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: