Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.4][regression] html tag is not rendered under certain circumstances #7106

Closed
jacekkarczmarczyk opened this issue Nov 22, 2017 · 4 comments

Comments

@jacekkarczmarczyk
Copy link

jacekkarczmarczyk commented Nov 22, 2017

Version

2.5.4

Reproduction link

https://codepen.io/anon/pen/XzEwwX?editors=1010

Steps to reproduce

Just open the link

What is expected?

Generated markup:

<span class="badge__badge red">
   <i data-v-fd715c0e="" aria-hidden="true" class="material-icons icon icon--right theme--dark">plus_one</i>
</span>

What is actually happening?

Generated markup:

   <i data-v-fd715c0e="" aria-hidden="true" class="material-icons icon icon--right theme--dark">plus_one</i>

It fails since 2.5.4, with 2.5.3 works fine
https://codepen.io/anon/pen/pdVoZy?editors=1010

Tried to make a minimal case without other dependencies here https://codepen.io/anon/pen/PORMVb?editors=1010 but couldn't get it to work, maybe somehow will be helpful, maybe not

Original issue: vuetifyjs/vuetify#2603

I'm suspecting that the bug is caused by the following commit 13196b2

Component that fails is here: https://github.com/vuetifyjs/vuetify/blob/master/src/components/VBadge/VBadge.js#L40

Commenting the following method fixes the rendering: https://github.com/vuetifyjs/vuetify/blob/master/src/components/VGrid/VContent.js#L14

@posva
Copy link
Member

posva commented Nov 22, 2017

Hi!
Thanks a lot for taking the time to dive in and look further to understand where it came from 🙂
However, we would appreciate boiled down repro without third-party libraries 😅
Also, make sure to use the last version of vue
To me, your repro reloads forever

@jacekkarczmarczyk
Copy link
Author

That's the problem, I'm not sure what exactly is happening there so I wasn't able to create a working (I mean failing) minimal repro :/ Will try again though
And repro reloading forever is a codepen issue I guess.

@yyx990803
Copy link
Member

Please open the issue at Vuetify's repo first - we can only track bugs that are known to be caused by Vue core itself.

@jacekkarczmarczyk
Copy link
Author

jacekkarczmarczyk commented Nov 22, 2017

Took me a while to create a repro without external libs - here it is: https://codepen.io/anon/pen/KyRWpN?editors=1010

What is expected

"I should be visible" text should be visible

What is actually happening

"I should be visible" is not rendered

More info

Text is visible if

  • data() returns "isContentActive: true", or
  • lines 10-13 are commented out, or
  • v-three component is not functional, or
  • vue 2.5.3 is used

@yyx990803 yyx990803 reopened this Nov 22, 2017
lovelope pushed a commit to lovelope/vue that referenced this issue Feb 1, 2018
f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this issue Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants