Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computed property don't receive component's instance as first argument in SSR #8977

Closed
sqal opened this issue Oct 22, 2018 · 1 comment · Fixed by #9090
Closed

Computed property don't receive component's instance as first argument in SSR #8977

sqal opened this issue Oct 22, 2018 · 1 comment · Fixed by #9090
Labels

Comments

@sqal
Copy link
Contributor

sqal commented Oct 22, 2018

Version

2.5.17

Reproduction link

https://github.com/sqal/vue-ssr-bug-reproduction

Steps to reproduce

  • Clone, install dependencies
  • run npm run ssr:serve

What is expected?

Should render the app.

What is actually happening?

When you start the server you should see that application throws following error: Cannot read property '$store' of undefined. This happens because in SSR computed property don't receive component's instance as the first argument, therefore I cannot access $store property. I am not sure if this is a bug or not, I think it is because i could not find anything about in vue or vue-ssr docs. I would appreciate if someone could clarify this issue. Thank you :)

@posva posva added the bug label Oct 22, 2018
@posva
Copy link
Member

posva commented Oct 22, 2018

I was sure I opened an issue or PR about this but apparently I didn't 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants