Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid possible infinite loop by accessing observables in error handler (fix vuex#1505) #9489

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Feb 13, 2019

fix vuejs/vuex#1505

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The original issue is vuejs/vuex#1505
When we touch some observables in errorCaptured hook, it is registered as dependency of the rendered component. Then the infinite rendering loop happens if we update the value inside the hook.

Updated reproduction which does not have Vuex store is here. https://codesandbox.io/s/ypvy7zn9xx

@yyx990803 yyx990803 merged commit ee29e41 into vuejs:dev Feb 18, 2019
@ktsn ktsn deleted the avoid-infinite-render-error-captured branch February 19, 2019 04:10
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Loop With Error Handler And Vuex
2 participants