Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix props & computed proto #11756

Closed
wants to merge 43 commits into from
Closed

Conversation

LongTengDao
Copy link

@LongTengDao LongTengDao commented Nov 8, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Key in Object.prototype does not work right for props / computed before this PR.

NOTICE: here still leave constructor that can't use, even after I replaced all constructor to _constructor in the source code, if I remove line Vue.prototype.constructor = Vue (in /src/core/instance/index.js) for the last step, here will always be one test fail (ci/circleci: test-e2e). I can not figure out why:

   - basic SSR (664ms)
   Testing if element <#result> contains text: "<div data-server-rendered="true">foo</div>".  - expected "<div data-server-rendered="true">foo</div>" but got: "TypeError: undefined is not an object (evaluating 'Vue.super')"
       at Object.basic SSR (/root/project/vue/test/e2e/specs/basic-ssr.js:5:15)
       at processTicksAndRejections (internal/process/task_queues.js:79:11)

@LongTengDao LongTengDao changed the title fix proto bug fix props & computed proto Nov 9, 2020
@posva
Copy link
Member

posva commented Nov 9, 2020

Thank you although there doesn't seem to be a problem here. Maybe you should open an bug report with a reproduction first

@posva posva closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants