Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test whether a property is configurable before defining it as reactive #2394

Merged
merged 2 commits into from Feb 28, 2016
Merged

Test whether a property is configurable before defining it as reactive #2394

merged 2 commits into from Feb 28, 2016

Conversation

saul
Copy link

@saul saul commented Feb 25, 2016

Fixes #2393

@yyx990803
Copy link
Member

Thanks, after some thinking, I think we can just use convertAllProperties behavior as the default and remove that config altogether.

@yyx990803 yyx990803 mentioned this pull request Feb 27, 2016
Closed
@saul
Copy link
Author

saul commented Feb 27, 2016

Do you want me to make that change in this PR?

@yyx990803
Copy link
Member

Yes please.

@saul
Copy link
Author

saul commented Feb 27, 2016

Done :)

yyx990803 added a commit that referenced this pull request Feb 28, 2016
@yyx990803
Merge pull request #2394 from saul/2393-observe-non-configurable
5a51b4a 
Test whether a property is configurable before defining it as reactive
@yyx990803 yyx990803 merged commit 5a51b4a into vuejs:dev Feb 28, 2016
@yyx990803
Copy link
Member

Great job, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saul @yyx990803