Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ns within foreignObject node.fix #6642 #6665

Closed
wants to merge 4 commits into from

Conversation

defcc
Copy link
Member

@defcc defcc commented Sep 22, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

fix #6642

@yyx990803
Copy link
Member

Thanks for the PR! Could use a simpler fix by adding an argument to applyNS: cf1ff5b (also avoids the perf cost of extra inline functions)

@yyx990803 yyx990803 closed this Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed HTML into an HTML5 SVG fragment got wrong namespace in template
2 participants