New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weex): stop trim css units in richtext component #6927

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@Hanks10100
Collaborator

Hanks10100 commented Oct 26, 2017

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

Other information:

The native render engine of Weex supports the px unit, and recommend writing CSS units.

  • Remove the trimCSSUnit method.
  • Modify the test cases to support CSS units.
  • Add flow type annotations.
fix(weex): stop trim css units in richtext component
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.

@Hanks10100 Hanks10100 added the weex label Oct 26, 2017

@yyx990803 yyx990803 merged commit 8a784d8 into vuejs:dev Oct 31, 2017

1 check passed

ci/circleci: test-e2e Your tests passed on CircleCI!
Details

erweixin pushed a commit to erweixin/vue that referenced this pull request Dec 15, 2017

fix(weex): stop trim css units in richtext component (vuejs#6927)
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.

lovelope added a commit to lovelope/vue that referenced this pull request Feb 1, 2018

fix(weex): stop trim css units in richtext component (vuejs#6927)
+ Remove the `trimCSSUnit` method.
+ Modify the test cases to support css units.
+ Add flow type annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment