feat(weex): adjust framework entry APIs and add flow annotations #7272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is used to achieve multi-instance isolation of Weex. Weex is planning to execute each page's code in different js context. Source codes and js contexts will be managed by the customed js engine within Weex core. See the discussions on Weex's mailing list: https://lists.apache.org/thread.html/87bf83253ed7ee318a8cf98d693bc534b3e08b4d28655a1290f2e0c7@%3Cdev.weex.apache.org%3E |
1. Remove the "init", "reset", "getRoot" and "receiveTasks" APIs, which are already implemented in the new version of "weex-js-runtime". 2. Use "createInstanceContext" instead of "createInstance". Vue only needs to prepare the instance context and no longer execute the js code. The js code will be executed by native. 3. Add flow type declarations and annotations.
Hanks10100
force-pushed
the
weex-sandbox
branch
from
18a4597 to
1cd4846
Compare
lovelope
pushed a commit
to lovelope/vue
that referenced
this pull request
Feb 1, 2018
…js#7272) 1. Remove the "init", "reset", "getRoot" and "receiveTasks" APIs, which are already implemented in the new version of "weex-js-runtime". 2. Use "createInstanceContext" instead of "createInstance". Vue only needs to prepare the instance context and no longer execute the js code. The js code will be executed by native. 3. Add flow type declarations and annotations.
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
…js#7272) 1. Remove the "init", "reset", "getRoot" and "receiveTasks" APIs, which are already implemented in the new version of "weex-js-runtime". 2. Use "createInstanceContext" instead of "createInstance". Vue only needs to prepare the instance context and no longer execute the js code. The js code will be executed by native. 3. Add flow type declarations and annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information:
Remove legacy framework APIs
Remove the
init,reset,getRootandreceiveTasksAPIs, which are already implemented in the new version ofweex-js-runtime.Moreover, the deprecated timer APIs should also be removed when they were supported by native render engines (C++ timers).
No longer execute the js code at front-end
Use
createInstanceContextinstead ofcreateInstanceto create the Vue module instance for each page. The Vue framework only needs to prepare the instance context and no longer execute the js code. The js code will be executed by native render engines.Flow type declarations
Add more reliable flow type declarations of Weex instance APIs and DOM APIs, and add type annotations for the entry file.