Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): add support for scoped slot pass down in templates (fix #7178) #7351

Closed
wants to merge 1 commit into from

Conversation

shameleo
Copy link

@shameleo shameleo commented Dec 31, 2017

fix #7178

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Need review, I'm not good at vue internals.
ESLint check in pre-commit script was skipped because of "eslint: command not found" error. Anyway, it was performed during build phase.
Happy New Year!

@shameleo shameleo changed the title feat(compiler): add support for scoped slot pass down in templates feat(compiler): add support for scoped slot pass down in templates (fix #7178) Dec 31, 2017
@yyx990803
Copy link
Member

Thanks for the PR. A less-intrusive implementation is found in #7765 which should address the same need.

@yyx990803 yyx990803 closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to pass scoped slots to descedants in templates
3 participants