New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Replace "var" #8299

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@slichlyter12
Contributor

slichlyter12 commented Jun 5, 2018

Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules to help with the migration to ES6.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@sodatea

package-lock.json should be excluded from the commits, for the following reasons:

  1. We already have a yarn.lock file;
  2. Lockfiles should only be updated when we have to, with great caution and thorough testing.

The rest of the PR seems fine.

@slichlyter12 slichlyter12 force-pushed the slichlyter12:toES6 branch from 739eb25 to da6e7cb Jun 12, 2018

refactor(core): Replace "var"
Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules

@slichlyter12 slichlyter12 force-pushed the slichlyter12:toES6 branch from da6e7cb to 50ebce0 Jun 12, 2018

@slichlyter12

This comment has been minimized.

Contributor

slichlyter12 commented Jun 12, 2018

I have removed package-lock.json from the commit.

@yyx990803 yyx990803 merged commit 5489339 into vuejs:dev Oct 24, 2018

1 check was pending

ci/circleci: install CircleCI is running your tests
Details

michaelromose added a commit to michaelromose/vue that referenced this pull request Nov 30, 2018

refactor(core): Replace "var" (vuejs#8299)
Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment