Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Replace "var" #8299

Merged
merged 2 commits into from Oct 24, 2018
Merged

refactor(core): Replace "var" #8299

merged 2 commits into from Oct 24, 2018

Conversation

slichlyter12
Copy link
Contributor

@slichlyter12 slichlyter12 commented Jun 5, 2018

Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules to help with the migration to ES6.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json should be excluded from the commits, for the following reasons:

  1. We already have a yarn.lock file;
  2. Lockfiles should only be updated when we have to, with great caution and thorough testing.

The rest of the PR seems fine.

Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules
@slichlyter12
Copy link
Contributor Author

I have removed package-lock.json from the commit.

@yyx990803 yyx990803 merged commit 5489339 into vuejs:dev Oct 24, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Replaces instances of "var" with "let" and "const" where applicable using the eslint 'no-var' and
'prefer-const' rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants