New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9042, #7138: handle empty placeholder case in IE #9297

Open
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
1 participant
@nciont
Copy link

nciont commented Jan 9, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Before this fix, the workaround for #9042 was to provide null or false value instead of empty string: :placeholder="placeholder || null".
The fix from #7138 was incomplete as it did not account for the case when placeholder attribute exists but is empty and the bug is not triggered in IE.
A new test case ensures the first triggered event does not get blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment