feat(refs): clear $firestoreRefs on $destroy

vuejs · Nov 17, 2017 · 250a4f9 · 250a4f9
1 parent d7a90ee
commit 250a4f9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -101,6 +101,7 @@ function install (Vue, options) {
         unbind()
       })
       this._firestoreUnbinds = null
+      this.$firestoreRefs = null
     }
   })
 

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -57,9 +57,15 @@ test('setups _firestoreUnbinds with no firestore options', t => {
   t.deepEqual(Object.keys(vm._firestoreUnbinds), [])
 })
 
-test('setups _firestoreRefs', t => {
+test('setups $firestoreRefs', t => {
   const vm = t.context.vm
   t.deepEqual(Object.keys(vm.$firestoreRefs).sort(), ['item', 'items'])
   t.is(vm.$firestoreRefs.item, t.context.document)
   t.is(vm.$firestoreRefs.items, t.context.collection)
 })
+
+test('clears $firestoreRefs on $destroy', t => {
+  const vm = t.context.vm
+  vm.$destroy()
+  t.deepEqual(vm.$firestoreRefs, null)
+})