test(ids): make sure id is kept in documents

Also make sure id is non enumerable, writable, nor configurable
vuejs · Dec 24, 2017 · 5b06306 · 5b06306
1 parent 14a6c55
commit 5b06306
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -10,6 +10,10 @@ function isObject (o) {
 }
 
 export function extractRefs (doc, path = '', result = [{}, {}]) {
+  const idDescriptor = Object.getOwnPropertyDescriptor(doc, 'id')
+  if (idDescriptor && !idDescriptor.enumerable) {
+    Object.defineProperty(result[0], 'id', idDescriptor)
+  }
   return Object.keys(doc).reduce((tot, key) => {
     const ref = doc[key]
     // if it's a ref

diff --git a/test/document.spec.js b/test/document.spec.js
@@ -2,6 +2,7 @@ import Vuefire from '../src'
 import {
   db,
   tick,
+  Key,
   Vue
 } from './helpers'
 
@@ -41,3 +42,15 @@ test('updates a document', async () => {
   await document.update({ bar: 'bar' })
   expect(vm.item).toEqual({ foo: 'foo', bar: 'bar' })
 })
+
+test('adds non-enumerable id', async () => {
+  document = collection.doc(new Key('some-id'))
+  await document.update({ foo: 'foo' })
+  await vm.$bind('item', document)
+  expect(Object.getOwnPropertyDescriptor(vm.item, 'id')).toEqual({
+    configurable: false,
+    enumerable: false,
+    writable: false,
+    value: 'some-id'
+  })
+})