Skip to content

Commit

Permalink
Set mergeStrats to data
Browse files Browse the repository at this point in the history
Allow merging firebase options when defined as functions
  • Loading branch information
posva committed Apr 3, 2017
1 parent dc8a416 commit 720c24c
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vuefire.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,9 @@ function install (_Vue) {
Vue = _Vue
Vue.mixin(VueFireMixin)

// use object-based merge strategy
// use data-like merge strategy
var mergeStrats = Vue.config.optionMergeStrategies
mergeStrats.firebase = mergeStrats.methods
mergeStrats.firebase = mergeStrats.data

// extend instance methods
Vue.prototype.$bindAsObject = function (key, source, cancelCallback, readyCallback) {
Expand Down
26 changes: 26 additions & 0 deletions tests/vuefire.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1012,4 +1012,30 @@ describe('VueFire', function () {
})
})
})

describe('mixins', function () {
var mixinFn
beforeEach(function () {
mixinFn = {
firebase: function () {
return {
items: firebaseRef.child('items')
}
}
}
})

it('func/func', function () {
var vm = new Vue({
firebase: function () {
return {
item: firebaseRef.child('first')
}
},
mixins: [mixinFn]
}).$mount()
expect(vm.items).to.not.be.undefined
expect(vm.item).to.not.be.undefined
})
})
})

0 comments on commit 720c24c

Please sign in to comment.