feat: make .key and .value read only

All properties default to false so I basically removed them all.
vuejs · Apr 15, 2018 · 7419c27 · 7419c27
1 parent 6978730
commit 7419c27
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/examples/todo-app/index.html b/examples/todo-app/index.html
@@ -3,7 +3,7 @@
   <head>
     <meta charset="utf-8">
     <title>VueFire Todo App Demo</title>
-    <script src="https://www.gstatic.com/firebasejs/4.2.0/firebase.js"></script>
+    <script src="https://www.gstatic.com/firebasejs/4.11.0/firebase.js"></script>
     <script src="https://unpkg.com/vue/dist/vue.js"></script>
     <script src="../../dist/vuefire.js"></script>
   </head>

diff --git a/src/vuefire.js b/src/vuefire.js
@@ -52,16 +52,10 @@ function createRecord (snapshot) {
   } else {
     res = {}
     Object.defineProperty(res, '.value', {
-      enumerable: false,
-      configurable: true,
-      writable: true,
       value: value
     })
   }
   Object.defineProperty(res, '.key', {
-    enumerable: false,
-    configurable: true,
-    writable: true,
     value: _getKey(snapshot)
   })
   return res