feat(refs): unbinds refs when removing from collection

vuejs · Dec 26, 2017 · 7abe7d6 · 7abe7d6
1 parent 778158e
commit 7abe7d6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -95,7 +95,10 @@ function bindCollection ({
     },
     removed: ({ oldIndex }) => {
       array.splice(oldIndex, 1)
-      // TODO remove listeners of nested refs
+      const subs = arraySubs.splice(oldIndex, 1)[0]
+      for (const subKey in subs) {
+        subs[subKey].unbind()
+      }
     }
   }
 

diff --git a/test/refs-collections.spec.js b/test/refs-collections.spec.js
@@ -98,7 +98,17 @@ test('unbinds nested refs when the collection is unbound', async () => {
   expect(spyA).toHaveBeenCalledTimes(0)
 
   vm.$unbind('items')
+  expect(spyA).toHaveBeenCalledTimes(1)
+
+  spyA.mockRestore()
+})
+
+test('unbinds refs when items are removed', async () => {
+  const spyA = spyUnbind(a)
+  await vm.$bind('items', collection)
+  expect(spyA).toHaveBeenCalledTimes(0)
 
+  await collection.doc(a.id).delete()
   expect(spyA).toHaveBeenCalledTimes(1)
 
   spyA.mockRestore()