refactor(mock): collection.doc(id) instead of collection.doc(new Key(…

…id))
vuejs · Dec 26, 2017 · a47cb8d · a47cb8d
1 parent 5bf1ffe
commit a47cb8d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/test/collection.spec.js b/test/collection.spec.js
@@ -33,7 +33,7 @@ test('add elements', async () => {
 
 test('delets items', async () => {
   await collection.add({ text: 'foo' })
-  await collection.doc(new Key(vm.items[0].id)).delete()
+  await collection.doc(vm.items[0].id).delete()
   expect(vm.items).toEqual([])
 })
 
@@ -65,8 +65,8 @@ test('unbinds when the instance is destroyed', async () => {
 })
 
 test('adds non-enumerable id', async () => {
-  const a = await collection.doc(new Key('u0'))
-  const b = await collection.doc(new Key('u1'))
+  const a = await collection.doc('u0')
+  const b = await collection.doc('u1')
   await a.update({})
   await b.update({})
   expect(vm.items.length).toBe(2)

diff --git a/test/document.spec.js b/test/document.spec.js
@@ -35,7 +35,7 @@ test('updates a document', async () => {
 })
 
 test('adds non-enumerable id', async () => {
-  document = collection.doc(new Key('some-id'))
+  document = collection.doc('some-id')
   await document.update({ foo: 'foo' })
   await vm.$bind('item', document)
   expect(Object.getOwnPropertyDescriptor(vm.item, 'id')).toEqual({

diff --git a/test/helpers/mock.js b/test/helpers/mock.js
@@ -129,7 +129,7 @@ class CollectionReference {
   where () {}
 
   doc (id) {
-    id = id || new Key()
+    id = new Key(id)
     return this.data[id.v] || new DocumentReference({
       collection: this,
       id,

diff --git a/test/refs-collections.spec.js b/test/refs-collections.spec.js
@@ -109,7 +109,7 @@ test('unbinds refs when items are removed', async () => {
   await vm.$bind('items', collection)
   expect(spyA).toHaveBeenCalledTimes(0)
 
-  await collection.doc(new Key(vm.items[0].id)).delete()
+  await collection.doc(vm.items[0].id).delete()
   expect(spyA).toHaveBeenCalledTimes(1)
 
   spyA.mockRestore()