-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update form-validation.md #2410
Conversation
Updates the server side code. Fixes vuejs#2391
I removed the server side code and updated the form code to use the right URL.
I've updated the commit (hopefully correctly) to remove the server side code. |
Update related to comments.
I believe I hit everything you said, except removing the async handler from the server-side code as Netlify didn't seem to like that (I would get CORS errors despite it still being in the "real" code). |
Just checking - are my updates ok? |
Hey @cfjedimaster! Just wanted to let you know that @phanan is out for a few days; but I'll check in with him when he gets back regarding this PR. |
@cfjedimaster In the meantime, could you run your code snippets through a linter / Prettier to keep it consistent in the docs? Happy to help format it for you if you don't have time. In the future, we'll probably plan on having auto-linting / formatting config in the repo to help reduce these sort of stylistic PR changes; so we appreciate your patience with this in the meantime! |
I'd be happy with yall formatting it as you see fit. :) (Yes, being a bit lazy.) |
Just checking in. If you tell me the linting/prettier settings you want I'll do it. This PR is now over two months old and I'd like to get it wrapped. ;) |
Anything I can do to get this shipped? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting some very minor CS fixes.
Hey Raymond! Terribly sorry, I totally missed this after getting back from my vacation. I've taken the liberty to |
No worries and thank you for pushing this out! |
Updates the server side code. Fixes #2391