Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form-validation.md #2410

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Update form-validation.md #2410

merged 7 commits into from
Mar 4, 2020

Conversation

cfjedimaster
Copy link
Contributor

Updates the server side code. Fixes #2391

Updates the server side code. Fixes vuejs#2391
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
src/v2/cookbook/form-validation.md Show resolved Hide resolved
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
src/v2/cookbook/form-validation.md Show resolved Hide resolved
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
I removed the server side code and updated the form code to use the right URL.
@cfjedimaster
Copy link
Contributor Author

I've updated the commit (hopefully correctly) to remove the server side code.

Update related to comments.
@cfjedimaster
Copy link
Contributor Author

I believe I hit everything you said, except removing the async handler from the server-side code as Netlify didn't seem to like that (I would get CORS errors despite it still being in the "real" code).

@cfjedimaster
Copy link
Contributor Author

Just checking - are my updates ok?

@bencodezen
Copy link
Member

Just checking - are my updates ok?

Hey @cfjedimaster! Just wanted to let you know that @phanan is out for a few days; but I'll check in with him when he gets back regarding this PR.

@bencodezen
Copy link
Member

@cfjedimaster In the meantime, could you run your code snippets through a linter / Prettier to keep it consistent in the docs? Happy to help format it for you if you don't have time.

In the future, we'll probably plan on having auto-linting / formatting config in the repo to help reduce these sort of stylistic PR changes; so we appreciate your patience with this in the meantime!

@cfjedimaster
Copy link
Contributor Author

I'd be happy with yall formatting it as you see fit. :) (Yes, being a bit lazy.)

@cfjedimaster
Copy link
Contributor Author

Just checking in. If you tell me the linting/prettier settings you want I'll do it. This PR is now over two months old and I'd like to get it wrapped. ;)

@cfjedimaster
Copy link
Contributor Author

Anything I can do to get this shipped?

Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting some very minor CS fixes.

src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
src/v2/cookbook/form-validation.md Outdated Show resolved Hide resolved
@phanan phanan merged commit a1fa9c3 into vuejs:master Mar 4, 2020
@phanan
Copy link
Member

phanan commented Mar 4, 2020

Hey Raymond! Terribly sorry, I totally missed this after getting back from my vacation. I've taken the liberty to butcher apply some linting to your PR and it should be fine to merge now 🙌. Thanks for the effort, and again, apologies for being super late on this.

@cfjedimaster
Copy link
Contributor Author

No worries and thank you for pushing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cookbook] Form validation throws CORS error for a codepen sample
4 participants