Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1107: re-enable scroll to anchor behavior #1108

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

janvennemann
Copy link
Contributor

Summary

Re-eneable the scroll to anchor behavior in Vue router.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:
Fixes #1107

@dimitrieh
Copy link

works 👍 but does not fix the problem noted at #1107 (comment) although that should, in that case, be scoped off to another issue 😉

@janvennemann
Copy link
Contributor Author

@ulivz as per comments from #1075, handling the hash portion in scrollBehavior appearantly has some issues with the active header links plugin. I guess that is because the plugin constantly replaces the URL to get the sidebar updated.

Any plans how to proceed with these constant issues? We have made our own version of the active header links plugin which does not rely on route updates for a secondary sidebar we use. I can try and adopt that implementation into @vuepress/plugin-active-header-links

@ulivz
Copy link
Member

ulivz commented Dec 17, 2018

This PR only solved a part of the problems, in fact, you can refer to the implementation of 0.x. but I can merge it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor link not jump
3 participants