Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong editLink in default-theme with index.md #1115

Closed
1 task done
meteorlxy opened this issue Dec 18, 2018 · 1 comment
Closed
1 task done

Wrong editLink in default-theme with index.md #1115

meteorlxy opened this issue Dec 18, 2018 · 1 comment
Labels
has PR Has a related PR type: enhancement Request to enhance an existing feature
Projects
Maintenance

Comments

@meteorlxy
Copy link
Member

  • I confirm that this is a issue rather than a question.

Bug report

Version

v1.0.0-alpha.29

Steps to reproduce

vuepress/packages/@vuepress/theme-default/components/Page.vue

Line 125 in 1c2aa08

path += 'README.md'

What is expected?

Both index.md and README.md are supported.

What is actually happening?

Wrong path if using index.md instead of README.md as the index filename.

Possible solution

Add an extra config field like indexFileName, which is set to README.md by default.
@meteorlxy meteorlxy changed the title Wrong editLink default-theme with index.md Wrong editLink in default-theme with index.md Dec 18, 2018
@ulivz ulivz added the type: enhancement Request to enhance an existing feature label Dec 18, 2018
@ulivz
Copy link
Member

ulivz commented Dec 18, 2018

Truly an issue and first reported at #1021

@meteorlxy meteorlxy mentioned this issue Feb 26, 2019
Merged
@shigma shigma added this to To do in Maintenance Mar 8, 2019
@shigma shigma added the has PR Has a related PR label Mar 8, 2019
@shigma shigma mentioned this issue Mar 8, 2019
Merged
18 tasks
@shigma shigma moved this from To do to In progress in Maintenance Mar 8, 2019
@ulivz ulivz closed this as completed in 3b14375 Mar 12, 2019
@shigma shigma moved this from In progress to Done in Maintenance Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR Has a related PR type: enhancement Request to enhance an existing feature
Projects
Maintenance
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meteorlxy @ulivz @shigma