Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #1154: use semantically more meaningful tags #1156

Merged

Conversation

HerrBertling
Copy link
Contributor

@HerrBertling HerrBertling commented Jan 3, 2019

Summary

See #1154 for info – this replaces some divs with header/main/aside tags and adds an aria landmark to the search

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No (not that I am aware of, at least)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

Merging this PR closes #1154

by replacing some `div`s with `header`/`main`/`aside` tags
and adding an aria landmark to the search
@HerrBertling
Copy link
Contributor Author

HerrBertling commented Jan 3, 2019

Just checked in IE – forgot to set display: block for the main element. Additional commit incoming!

Also, I should get my author mail address & name in order between work and private machine 🙈

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks!

@ulivz ulivz merged commit ede57b0 into vuejs:master Jan 8, 2019
@HerrBertling HerrBertling deleted the feat/1154-default-theme-semantic-markup branch January 9, 2019 08:17
@nelson6e65
Copy link
Contributor

There is a typo introduced by this pr. Please check fix in #1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Use semantic HTML in default theme
3 participants