Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-blog): read layoutComponents from themeAPI #1396

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

jkzing
Copy link
Member

@jkzing jkzing commented Mar 4, 2019

Summary

It seems layoutComponentMap has been refactored into themeAPI, correct the reference in plugin-blog.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

BTW, we're planning to refactor the blog plugin because of its limitations. here's the roadmap: https://github.com/vuejs/vuepress/projects/1.

@ulivz ulivz merged commit 5bf4d24 into vuejs:master Mar 4, 2019
@jkzing
Copy link
Member Author

jkzing commented Mar 5, 2019

@ulivz , good to know, can't wait to see it. :)

@ulivz
Copy link
Member

ulivz commented Mar 9, 2019

Available at 1.0.0-alpha.43.

@jkzing jkzing deleted the fix-blog branch March 11, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants