refactor($theme-default): extract page components #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieutu
force-pushed
the
extract-page-components
branch
from
f933be4
to
ec64dac
Compare
mathieutu
changed the title
mathieutu
changed the title
|
//cc @shigma |
|
(I think the more we'll split templates in small components the more it'll be easy to use and overwrite them.) |
|
Maybe could we merge it, then? |
|
I know it's been a while since you create the pr @mathieutu i will have a look soon. It look great can you just please resolve the conflict please ? We will need to update the doc part too about it |
flozero
added
complexity: easy
|
Before approve it i have to check the theme override on it if it's working or not but it look good |
flozero
approved these changes
Sep 7, 2019
|
Hey @mathieutu, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi,
This PR extract the Edit and Nav components from default theme Page component.
It allows us to replace easily theses components when extending the template, by replacing only the targeted component and not the whole page.
There is no any change visually speaking.
Thanks for your work!
Matt'
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.