Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm install and npm test to CI #1452

Open
bnb opened this issue Mar 15, 2019 · 4 comments
Open

Add npm install and npm test to CI #1452

bnb opened this issue Mar 15, 2019 · 4 comments
Labels
contribution welcome Contributions welcome

Comments

@bnb
Copy link

bnb commented Mar 15, 2019

Feature request

Add npm install and npm test to the CircleCI build scripts.

What problem does this feature solve?

Currently, the website's front-page implicitly suggests that npm i -g vuepress should work just as well as yarn global add vuepress:

image

It would be awesome to get that same assertion of support in the CI builds so that y'all can ensure there are no possible npm CLI issues before they may be shipped.

The way Yarn and npm resolve dependencies is slightly differently – meaning of the yarn CLI could have a totally fine experience but npm CLI could have an absolutely horrible one. Additionally, Yarn makes no guarantees that dependency resolution will only change with semver major release which only exacerbates this concern as an npm CLI user.

How should this be implemented in your opinion?

Probably as a secondary CI build – i.e. not in the same container as Yarn builds – so you don't have cross-contamination between the two builds.

Are you willing to work on this yourself?

Would be happy to!

@ulivz ulivz added the contribution welcome Contributions welcome label Mar 16, 2019
@ulivz
Copy link
Member

ulivz commented Mar 16, 2019

Contribution welcome!

@jamesgeorge007
Copy link
Contributor

@bnb Are you working on this?
@ulivz I would be happy to pick this up if that's not the case 👏

@ulivz
Copy link
Member

ulivz commented Mar 27, 2019

@jamesgeorge007 Let go for it!

@jamesgeorge007
Copy link
Contributor

@ulivz As per what I see adding an npm install and npm test scripts to the CircleCI build config file is what required here 🤔 Kindly suggest me if there is anything worth to be noted 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome
Projects
None yet
Development

No branches or pull requests

3 participants