Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activeHeaderLinks config don't work in alpha release #1488

Closed
1 task done
oott123 opened this issue Mar 28, 2019 · 1 comment
Closed
1 task done

activeHeaderLinks config don't work in alpha release #1488

oott123 opened this issue Mar 28, 2019 · 1 comment
Labels
has PR Has a related PR topic: theme Relates to VuePress theme

Comments

@oott123
Copy link

oott123 commented Mar 28, 2019

  • I confirm that this is an issue rather than a question.

Bug report

Version

1.0.0-alpha.44

Steps to reproduce

create .vuepress/config.js:

module.exports = {
  themeConfig: {
    activeHeaderLinks: false,
    sidebar: 'auto',
  }
}

and add some docs with headers. Scroll and look at the url. Url is changing regardless of you set it to true or false.

What is expected?

Url is not change when you set activeHeaderLinks to false

What is actually happening?

Url is change when you set it to false

Other relevant information

  • Your OS: macOS 10.14.3
  • Node.js version: v8.12.0
  • Browser version: Google Chrome | 73.0.3683.86
  • Is this a global or local install? local
  • Which package manager did you use for the install? yarn
  • Does this issue occur when all plugins are disabled? actually is the bug in the default theme which enabled @vuepress/plugin-active-header-links by default.
@shigma
Copy link
Collaborator

shigma commented Apr 2, 2019

Fixed at #1508.

@shigma shigma added the has PR Has a related PR label Apr 2, 2019
@ulivz ulivz closed this as completed in 47c02ce Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Has a related PR topic: theme Relates to VuePress theme
Projects
None yet
Development

No branches or pull requests

2 participants