enhanceApp options should merge options we pass

[flozero]

Feature request

actually i am building additional page from components with docs

https://github.com/f3ltron/vuepress-plugin-docgen

// https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/core/lib/client/app.js#L88

const options = {}

  try {
    appEnhancers.forEach(enhancer => {
      if (typeof enhancer === 'function') {
        enhancer({ Vue, options, router, siteData, isServer })
      }
    })
  } catch (e) {
    console.error(e)
  }

  const app = new Vue(
    Object.assign(options, {
      router,
      render (h) {
        return h('div', { attrs: { id: 'app' }}, [
          h('router-view', { ref: 'layout' }),
          h('div', { class: 'global-ui' }, globalUIComponents.map(component => h(component)))
        ])
      }
    })
  )

What problem does this feature solve?

when we use some front plugin like vue18n in my case by letting me merge my options into options there will be no more bug for $t is not define

What does the proposed API look like?

The merge should merge dynamically our options

Are you willing to work on this yourself?

i can if it's accepted

[ulivz]

Sorry for the delay to see this pull request, do you still need it?

[flozero]

no problem yeah it could be great as the feature for me should exist when i watch the code. Maybe i am wrong ?

[MickaMx]

I'd be great to add that. I've been trying to import my vuetify component to vuepress but those components use vue-i18n and I can't find a way to make it work.
This feature could solve the problem

[flozero]

If i remember well it was exactly for that i created the issue because i faced the same probleme @MickaMx :)

[MickaMx]

Did you found a way around ? other than the code you've add in this issue?

[flozero]

This part of code should be update. I could create the PR but just need some validation on it

[flozero]

yeah i found something but really not stable

[flozero]

oh didnt remember ^ ^ i already created the pr @MickaMx #1632

[MickaMx]

Yep, I saw that. It didn't got merge yet ^^

[beatgrabe]

Wow. I have exactly the same problem now. I am really looking forward to have this merged.

[flozero]

We will publish it the next release

[meteorlxy]

What's the problem if we use Object.assign(options, {}) in current enhanceApp ?

// .vuepress/enhanceApp.js
import Vuex from 'vuex'

export default ({ Vue, options }) => {
  Vue.use(Vuex)

  const store = new Vuex.Store({
    state: {
      msg: 'hello'
    },
  })

  Object.assign(options, {
    store
  })
}

// README.md

{{ $store.state.msg }}

That works well.

🤔 So what's this FR for? Sorry if I misunderstood this FR.

[flozero]

@meteorlxy it change the option by reference ?

[flozero]

@meteorlxy answered to the question thx i am closing the issue