Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($plugin-pwa): work with register-service-worker 1.7.0 (close #2222) #2229

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

meteorlxy
Copy link
Member

Summary

close #2222

It's caused by yyx990803/register-service-worker#33 , which references window.addEventListener in the outer scope.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Other information:

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@billyyyyy3320 billyyyyy3320 merged commit 604052b into vuejs:master Mar 18, 2020
@Mister-Hope
Copy link
Contributor

Why not update to workbox-build@5.0.0 ?
I can help to open a PR.

@meteorlxy
Copy link
Member Author

Didn't have time to check if there are any useful features or breaking changes.

Contribution welcome.

@meteorlxy meteorlxy deleted the fix/pwa branch March 18, 2020 11:59
@Mister-Hope
Copy link
Contributor

workbox-build v5 make the build-in service worker the default and the only generating way.

Instead, v4's default is goolge-cdn.

Then I will make a PR for it.

@Mister-Hope
Copy link
Contributor

image
Would you mind I change the default popup? The default pop up does not look well on safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

register-service-worker 1.7.0 broke PWA plugin
4 participants