Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate slash when docsDir is not set #361

Merged
merged 2 commits into from
May 8, 2018
Merged

Avoid duplicate slash when docsDir is not set #361

merged 2 commits into from
May 8, 2018

Conversation

whoan
Copy link
Contributor

@whoan whoan commented May 8, 2018 •
edited
Loading

When docsDir is not set, the url to edit the document currently has two slashes.

ulivz
ulivz approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulivz ulivz merged commit 0c59ed5 into vuejs:master May 8, 2018
@whoan whoan deleted the slash branch May 8, 2018 14:31
@ulivz ulivz mentioned this pull request May 11, 2018
Closed
@ulivz
Copy link
Member

ulivz commented May 11, 2018

Will release it at 0.9.0: #419. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulivz ulivz ulivz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whoan @ulivz