Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix medium-zoom not updating on component update #994

Merged
merged 4 commits into from
Nov 13, 2018
Merged

馃悰 Fix medium-zoom not updating on component update #994

merged 4 commits into from
Nov 13, 2018

Conversation

dcastil
Copy link
Contributor

@dcastil dcastil commented Nov 10, 2018

Summary

medium-zoom doesn't get attached to newly loaded images when the user navigates to other routes within a vuepress project. The problem is that medium-zoom gets attached to currently available images when the LayoutDistributor is mounted, but not when it's updated (e.g. when the user navigates to a new route).

My fix detaches all images from medium-zoom when the LayoutDistributor updates (as images could have been removed from the DOM) and attaches all current images in the DOM which match the provided selector.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

I wanted to upgrade to medium-zoom v1.0.2 but the vuepress build command threw an error that the window object isn't defined. I don't understand why that happens as the window object is also used in v0.4.0. The error appears when medium-zoom tries to access window.Promise.

@dcastil dcastil changed the title 馃悰 Medium zoom not updating on component update 馃悰 Fix medium-zoom not updating on component update Nov 10, 2018
packages/@vuepress/plugin-medium-zoom/mixin.js Outdated Show resolved Hide resolved
packages/@vuepress/plugin-medium-zoom/mixin.js Outdated Show resolved Hide resolved
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 6aa4d91 into vuejs:master Nov 13, 2018
@dcastil dcastil deleted the bugfix/medium-zoom-update branch November 13, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants