feat(types): adding logger type for logger plugin #1853
Merged
Conversation
Thank you so much for the PR! yeah we totally forgot about I've made a comment. Could you have a look |
* createLogger options takes in logger which by default is console but can be overridden with own logger. * Adding Ilogger for logger options params which expects log method to be implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
can be overridden with own logger.
be implemented