Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): adding logger type for logger plugin #1853

Merged
merged 1 commit into from Oct 23, 2020

Conversation

@itomtom
Copy link
Contributor

@itomtom itomtom commented Oct 18, 2020

  • createLogger options takes in logger which by default is console but
    can be overridden with own logger.
  • Adding Ilogger for logger options params which expects log method to
    be implemented
Copy link
Member

@kiaking kiaking left a comment

Thank you so much for the PR! yeah we totally forgot about logger option hah...

I've made a comment. Could you have a look 🙏 ?

types/logger.d.ts Outdated Show resolved Hide resolved
@kiaking kiaking added the types label Oct 19, 2020
@itomtom itomtom force-pushed the itomtom:feat/types/logger branch from 73a8ddd to 5a74586 Oct 20, 2020
* createLogger options takes in logger which by default is console but
can be overridden with own logger.
* Adding Ilogger for logger options params which expects log method to
be implemented
@itomtom itomtom force-pushed the itomtom:feat/types/logger branch from 5a74586 to b974e01 Oct 21, 2020
@kiaking kiaking merged commit cb3198d into vuejs:dev Oct 23, 2020
6 checks passed
6 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants