feat(types): adding logger type for logger plugin #1853

itomtom · 2020-10-18T14:39:34Z

createLogger options takes in logger which by default is console but
can be overridden with own logger.
Adding Ilogger for logger options params which expects log method to
be implemented

kiaking

Thank you so much for the PR! yeah we totally forgot about logger option hah...

I've made a comment. Could you have a look 🙏 ?

types/logger.d.ts

* createLogger options takes in logger which by default is console but can be overridden with own logger. * Adding Ilogger for logger options params which expects log method to be implemented

kiaking requested changes Oct 19, 2020

View changes

types/logger.d.ts Outdated Show resolved Hide resolved

kiaking added the types label Oct 19, 2020

itomtom force-pushed the itomtom:feat/types/logger branch from 73a8ddd to 5a74586 Oct 20, 2020

feat(types): adding logger type for logger plugin

Loading status checks…

b974e01

* createLogger options takes in logger which by default is console but can be overridden with own logger. * Adding Ilogger for logger options params which expects log method to be implemented

itomtom force-pushed the itomtom:feat/types/logger branch from 5a74586 to b974e01 Oct 21, 2020

kiaking approved these changes Oct 23, 2020

View changes

vuejs / vuex

feat(types): adding logger type for logger plugin #1853

feat(types): adding logger type for logger plugin #1853

itomtom commented Oct 18, 2020

kiaking left a comment

vuejs / vuex

Sponsor vuejs/vuex

feat(types): adding logger type for logger plugin #1853

feat(types): adding logger type for logger plugin #1853

Conversation

itomtom commented Oct 18, 2020

kiaking left a comment