Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-button ignores type prop #41

Closed
ragnarlotus opened this issue Nov 1, 2016 · 1 comment
Closed

md-button ignores type prop #41

ragnarlotus opened this issue Nov 1, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@ragnarlotus
Copy link

ragnarlotus commented Nov 1, 2016

The following md-button
<md-button type="submit" class="md-raised md-primary">Save</md-button>

Is rendered as
<button type="button" class="md-button md-raised md-primary">Save</button>

So the type is always rendered as "button"

@marcosmoura marcosmoura self-assigned this Nov 2, 2016
@marcosmoura marcosmoura added this to the v0.2.1 milestone Nov 2, 2016
@marcosmoura marcosmoura added the bug label Nov 2, 2016
@marcosmoura
Copy link
Member

Hey. You're right. This is a ugly bug. Thanks for the PR and for reporting this.

marcosmoura added a commit that referenced this issue Nov 3, 2016
Fix for issue #41 (md-button ignores type prop)
@marcosmoura marcosmoura modified the milestones: v0.2.1, v0.3.0 Nov 11, 2016
marcosmoura added a commit that referenced this issue Nov 12, 2016
* origin/master:
  Fix for issue #41 (md-button ignoring type prop)
marcosmoura added a commit that referenced this issue Nov 13, 2016
* origin/develop:
  Create select with multiple
  Make md-select with md-menu
  Fix for issue #41 (md-button ignoring type prop)
  Finish md-menu spec
  Add keyboard shortcuts to menu
  Add close event on tab
  Close content on esc
  Drop transitionend dependency
  Keep menu content inside viewport
  Recalculate position on resize
  Add menu code in card example
  Add menu in a button text
  Add menu to card example
  Refactor huge method
  Make menu open in a correct position
  Add initial styles and detach and attach menu on click
  Force size of demo example
  Add page title
  Add menu tag
  Add empty md-menu files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants