Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdTabs): remove ResizeObserver #1552

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

Samuell1
Copy link
Member

Fix #1513

Maybe it can resolve #1500 ?

@mrwhy-orig
Copy link
Contributor

I can confirm that this fix + the fix #1506 is solving a part of #1500. But there is one case left. If there is a child md-tabs with only 1 md-tab it is not calculating the height.
I tried to demonstrate it with a pen, you have to use the "debug" view because the whole fix isn't working in editor view.
https://codepen.io/MrWhy/pen/QQZZme?editors=1111

@marcosmoura
Copy link
Member

@Samuell1 @mrwhy-orig We can merge this one and work on another fix for this case. Will be better.

@marcosmoura marcosmoura merged commit ef0cd2f into dev Feb 28, 2018
@marcosmoura marcosmoura deleted the fix/MdTabs/call-resize-functions branch February 28, 2018 18:12
@mrwhy-orig
Copy link
Contributor

@marcosmoura should I open another issue on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MdTabs] content height is not set with async data [MdTabs] content length calculations
3 participants