-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: corrections of breakpoints #1744
Conversation
@@ -39,6 +39,11 @@ | |||
<li v-for="event in interactionEvents" :key="event">{{ event }}</li> | |||
</ul> | |||
|
|||
<note-block> | |||
Mixing a list action with actions on the list items hurts usability. When clicking on the list item action, will the list action be triggered as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this tip a little confusing. Maybe we can have more examples to show why this will happen. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, maybe better will be to link to issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VdustR yes i know but i mean linking in docs to that issues will be better then examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we must do something better than just link with issues. Because this should not be an issue. What do guys think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can solve it if md-list-item, button can be transformed to div
tag, @marcosmoura
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree about <div>
if there is no better way to implement that.
* docs(Layout): correction of breakpoints * docs(MdList): add click usability note * docs(MdList): remove note
Resolves #1685