Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: corrections of breakpoints #1744

Merged
merged 3 commits into from
May 19, 2018
Merged

docs: corrections of breakpoints #1744

merged 3 commits into from
May 19, 2018

Conversation

Samuell1
Copy link
Member

@Samuell1 Samuell1 commented May 15, 2018

Resolves #1685

@@ -39,6 +39,11 @@
<li v-for="event in interactionEvents" :key="event">{{ event }}</li>
</ul>

<note-block>
Mixing a list action with actions on the list items hurts usability. When clicking on the list item action, will the list action be triggered as well?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this tip a little confusing. Maybe we can have more examples to show why this will happen. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, maybe better will be to link to issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #1653.

Probable solution #1680.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VdustR yes i know but i mean linking in docs to that issues will be better then examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must do something better than just link with issues. Because this should not be an issue. What do guys think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can solve it if md-list-item, button can be transformed to div tag, @marcosmoura

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about <div> if there is no better way to implement that.

@Samuell1 Samuell1 closed this May 18, 2018
@Samuell1 Samuell1 reopened this May 18, 2018
@Samuell1 Samuell1 changed the title docs: corrections and tips docs: corrections of breakpoints May 18, 2018
@marcosmoura marcosmoura merged commit 04912d1 into dev May 19, 2018
@VdustR VdustR deleted the docs/corrections-tips branch May 19, 2018 03:27
Pwntus pushed a commit to Pwntus/vue-material that referenced this pull request Jun 8, 2018
* docs(Layout): correction of breakpoints

* docs(MdList): add click usability note

* docs(MdList): remove note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants