Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type option in commentConfig in config.ts of the 2.0 project generated by theme cli was misspelled #258

Closed
1 task done
threeTrave opened this issue Nov 24, 2023 · 1 comment

Comments

@threeTrave
Copy link

threeTrave commented Nov 24, 2023

  • I confirm that this is an issue rather than a question.

Bug report

This is the commentConfig in the default config.ts file generated by theme cli, and the type attribute is' valie ', which is obviously incorrect
image
Judgment in the source code
image
In fact, this bug is very small, and upon closer inspection, you will find it, but it can bring about a bad experience, and it feels like it's not something to use right out of the box

What is actually happening?

Other relevant information

  • Your OS:
  • Node.js version: 20.10.0
  • VuePress version: 2.0.0-rc.0
  • VuePress-theme-reco version: 2.0.0-rc.1
  • Which package manager did you use for the install(npm/cnpm/yarn/pnpm)?npm & yarn
@recoluan
Copy link
Member

recoluan commented Jan 9, 2024

Thank you for your advice. I've fixed it in commit.

@recoluan recoluan closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants