Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected twitter:card without image #1591

Closed
Mister-Hope opened this issue Mar 18, 2022 · 0 comments
Closed

unexpected twitter:card without image #1591

Mister-Hope opened this issue Mar 18, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Mister-Hope
Copy link
Member

Page settings: no setting, default md file, text only, without image.

  [ 'meta', { name: 'twitter:card', content: 'summary_large_image' } ],
  [ 'meta', { name: 'twitter:image:alt', content: 'Chaldea' } ]

These two are always added even twitterId not set and without image. And og:image is also not added.
So I think it's better not to append twitter card tag when both are empty.
og:description is not added too, not sure where you parse this from.

Furthermore, when there is no image on this page, It can be fallback to site icon, and description fallback to <meta name="description">

Originally posted by @narumishi in #1587

@Mister-Hope Mister-Hope added bug Something isn't working v2 labels Mar 18, 2022
@Mister-Hope Mister-Hope self-assigned this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant