-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Note] Attention when using fontawesome #375
Comments
Hi there, after a few days I realise that there is still another bug (I'm still using FontAwesome) |
Well, there is a document about font-weight: |
The problem is that while fontawesome is changing font-weight in different types, iconfont is not setting it's font-weight. But iconfont icons do need a normal(400) font weight to make the icon appearance right. Tags like h1 and other classes in theme have different font-weight, which will affect the icon appearance, that's why I set a default I am hoping that the icon class user added have a higher priority. But I forgot users are adding a css link to the final css which will make the classes have a lower priority, which is not what I am expected. I didnot catch up with a better solution. Either I remove that style and let all the iconfont users to add that style in their index.styl, or I remain the style and let all the fontawesome users to add the style I list above. It's kind of document thing. Since more users are using iconfont, I am going to remain the style, and metion users to add extra style when using fontawesome in docs. If you have any ideas improving the situation, welcome to reply. |
Font awesome is supported in 1.7.0. |
For those who use fontawesome, please add these lines to your
index.styl
:The text was updated successfully, but these errors were encountered: