Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Mailto:XXX@yy.com is no longer worked after upgrade to 2.0.0-rc.22 #4044

Closed
6 of 8 tasks
lancy6001 opened this issue Apr 7, 2024 · 5 comments
Closed
6 of 8 tasks
Assignees
Labels
bug Something isn't working

Comments

@lancy6001
Copy link

lancy6001 commented Apr 7, 2024

Checklist

  • I am using LTS version of Node.js.
  • I am using the latest v2 version of VuePress and VuePress official plugins.
  • I am using the latest v2 version of vuepress-theme-hope and all plugins in this repo.
  • I followed the docs and I double checked my configuration.
  • I have searched FAQ and I did not find the answer.

Package name

vuepress-theme-hope

Which operating system are you using?

  • macOS
  • Windows
  • Linux

Describe the bug

I have a default navbar.ts file, and I add some contents like below:
{
text: "Contact Us",
children: [
{
text: "Email Support",
link:"mailto:XXXsupport@XXXtest.com",
//target: "_blank",
}

before upgrade, it is regard as mailto bebavior and will popup outlook to write an email.
But now it is regard as a html page like mailto:XXXsupport@XXXtest.com.html
Actually, this is not a page, but a mailto behavior. Please check and correct this behavior.

Additional context

image

@lancy6001 lancy6001 added the bug Something isn't working label Apr 7, 2024
@Mister-Hope
Copy link
Member

This is an upstream bug at vuepress core.

I tried to spend a few minutes searching protocol like this which can support it by browser but I haven't found any specification files that describe this.

Can you help to provide one?

urls like mailto: can be sepecial because they don't have full protocols like abc://

@Mister-Hope
Copy link
Member

Mister-Hope commented Apr 7, 2024

I have found https://www.rfc-editor.org/rfc/rfc6068, but since there are other early protocol like tel: https://www.rfc-editor.org/rfc/rfc5341.

I just want to make sure I can catch all of them

@Mister-Hope
Copy link
Member

Track vuepress/core#1528. To speed up the process, I sincerely invite you to help finding the full list of these protocols as they must be specially handled.

@Mister-Hope Mister-Hope closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@Mister-Hope Mister-Hope added upstream bug Bug comes from upstream, should not be fixed here and removed bug Something isn't working labels Apr 7, 2024
@Mister-Hope Mister-Hope reopened this Apr 7, 2024
@Mister-Hope Mister-Hope added bug Something isn't working and removed upstream bug Bug comes from upstream, should not be fixed here labels Apr 8, 2024
@lll4770
Copy link

lll4770 commented Apr 8, 2024

Hi @Mister-Hope , I saw you had fixed this issue. I'm new learner in the front-end, I'm using the vuepress-theme-hope in my project, my question is how can I get your fix in my project, currently, I found the version of vuepress-theme-hope in my project is "2.0.0-rc.22" in the package.json config file.

@Mister-Hope
Copy link
Member

Mister-Hope commented Apr 8, 2024

Just wait for a new version to land. That won't take long.

We don't create a patch release immediately for every bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants