Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Docsearch result incorrect #1223

Closed
Mister-Hope opened this issue Jan 5, 2023 · 4 comments · Fixed by #1224
Closed

[Bug report] Docsearch result incorrect #1223

Mister-Hope opened this issue Jan 5, 2023 · 4 comments · Fixed by #1224
Assignees
Labels
bug Something isn't working

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Jan 5, 2023

Description

When deploying docs at mutiplce places with different base, the other site cannot gent a search result correctly.

For example, vuepress-theme-hope has documentation on:

And currently docsearch is crawling the fiirst one, however, a https://vuepress-theme-hope.github.io/v2/test.html will be converted to a routerlink /v2/test.html

This will happens as long as docs are deployed at different base.

Solution

We may need a setting called indexBase so that when coverting to internal route link, the base can be removed correctly.

@meteorlxy
Copy link
Member

Well, I do think it's not a common use case and should not be encouraged...

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Jan 16, 2023

I do think it's a common usage for docs being deployed at multiple places, and let the crawler craw the "canonical link" while still support other sites to perform search.

Why shouldn't it a common usage? You mean people only deploy docs in one place? or people should only provide search on one site?

A lot of my users are deploying on netlify/gitee with their own domain, while also deploy on Gitee.com with base to as an CDN site for china mainland users, so what's your opinion toward their situation?

Gitee does not support custom domain before getting paid.

I am actually not caring about this as I already get the pacakge patched with my pr in my repo, however there are other users reporting similar issue like this in my group.

@meteorlxy
Copy link
Member

I mean multiple deployments with different base sounds not so common.

You mean people only deploy docs in one place?

Why do you think like that? We are using multiple deployments ourselves.

BTW, I suggest you not to be so aggressive when discussing

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Jan 16, 2023

As I mentioned, a lot of authors may choose gitee to provide accelarations in China mainland, and custom domain for gitee pages is not free, so people do need base for their projects as not everyone would like to create a new org for each project.

People usually do not use different base, you are right about this point, however there is no pages service in Mainland santisfying:

  • Totally Free
  • Fast and stable (Servers in china mainland)
  • Support custom domain

meteorlxy added a commit that referenced this issue Jan 16, 2023
Co-authored-by: meteorlxy <meteor.lxy@foxmail.com>
@Mister-Hope Mister-Hope added the bug Something isn't working label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants