New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug report] Docsearch result incorrect #1223
Comments
Well, I do think it's not a common use case and should not be encouraged... |
I do think it's a common usage for docs being deployed at multiple places, and let the crawler craw the "canonical link" while still support other sites to perform search. Why shouldn't it a common usage? You mean people only deploy docs in one place? or people should only provide search on one site? A lot of my users are deploying on netlify/gitee with their own domain, while also deploy on Gitee.com with base to as an CDN site for china mainland users, so what's your opinion toward their situation? Gitee does not support custom domain before getting paid. I am actually not caring about this as I already get the pacakge patched with my pr in my repo, however there are other users reporting similar issue like this in my group. |
I mean multiple deployments with different
Why do you think like that? We are using multiple deployments ourselves. BTW, I suggest you not to be so aggressive when discussing |
As I mentioned, a lot of authors may choose gitee to provide accelarations in China mainland, and custom domain for gitee pages is not free, so people do need base for their projects as not everyone would like to create a new org for each project. People usually do not use different base, you are right about this point, however there is no pages service in Mainland santisfying:
|
Description
When deploying docs at mutiplce places with different base, the other site cannot gent a search result correctly.
For example, vuepress-theme-hope has documentation on:
And currently docsearch is crawling the fiirst one, however, a
https://vuepress-theme-hope.github.io/v2/test.html
will be converted to a routerlink/v2/test.html
This will happens as long as docs are deployed at different base.
Solution
We may need a setting called
indexBase
so that when coverting to internal route link, the base can be removed correctly.The text was updated successfully, but these errors were encountered: