Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-docsearch): support indexBase option (close #1223) #1224

Merged
merged 3 commits into from Jan 16, 2023

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope Mister-Hope linked an issue Jan 6, 2023 that may be closed by this pull request
@meteorlxy
Copy link
Member

meteorlxy commented Jan 16, 2023

Do you think we need to support different indexBase in different locales?

@meteorlxy meteorlxy changed the title fix(plugin-docsearch): fix base issue, close #1223 feat(plugin-docsearch): support indexBase option (close #1223) Jan 16, 2023
@Mister-Hope
Copy link
Member Author

Mister-Hope commented Jan 16, 2023

Do you think we need to support different indexBase in different locales?

Maybe, I am not sure.

Since our locales is based on file structure and a bit hard to customize (there are hard links in serverl places like homepage frontmatter actions option, navbar options, sidebar options, etc), I am not expecting users to reorganize files with scripts or use permalinks to override them and deal all hard links.

For my users cases, they are not changing locales.


So, I do think maybe its fine to just provide an extra indexBase, if they are actually changing 2 sites, they may need to consider running another crawler as the firt choice?🤔

@meteorlxy
Copy link
Member

OK, let's keep it simple to meet most use cases. I've updated the docs and you could check it again.

@Mister-Hope
Copy link
Member Author

LGTM

@meteorlxy meteorlxy merged commit 23a4c68 into main Jan 16, 2023
@meteorlxy meteorlxy deleted the docsearch-base branch January 16, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Docsearch result incorrect
2 participants