Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank page when cookies blocked #589

Closed
AnWeber opened this issue Dec 25, 2021 · 4 comments
Closed

Blank page when cookies blocked #589

AnWeber opened this issue Dec 25, 2021 · 4 comments
Labels

Comments

@AnWeber
Copy link
Contributor

AnWeber commented Dec 25, 2021

I recently started using beta.29 to create my documentation. I noticed that when all cookies are blocked, a blank page is displayed. Tested on Android and Win10 in Chrome.

Steps:

  • Block Cookies in Browser
  • Visit httpyac.github.io
  • Site gets blank after first render
DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at https://httpyac.github.io/assets/app.7644c1a0.js:7:14854

Probably created by vueuse by using useStorage in this line for the use of darkMode. Should vuepress itself check the usage of the localStorage, or is this the task of vueuse?

@meteorlxy
Copy link
Member

Uh, I think it might be better to open an issue in vueuse for that 🤔

@AnWeber
Copy link
Contributor Author

AnWeber commented Dec 27, 2021

@meteorlxy I have submitted a bug/feature request to vueuse. Until the change is incorporated into useStorage, would it be possible to implement feature detection in vuepress? I would provide both a PR for the implementation and also for the removal after a update is available.

@github-actions github-actions bot added the stale label Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 3 days.

@AnWeber
Copy link
Contributor Author

AnWeber commented Jan 4, 2022

PR provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants