fix(bundler-webpack): add conditionNames to import correct file #1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://webpack.js.org/configuration/resolve/#resolveconditionnames
This solves a lot of issues.
I previously use alias with conditional checks (app.env.isDev, app.env.isBuild and bundler names) to ensure the correct file is used, but this can obviously fixed upstream here.
For example, when importing
@vue/repl
with webpack,@vue/repl
importvue/component-sfc
in it. And the latter use a condition export like this:Then webpack should pack
./dist/compiler-sfc.esm-browser.js
for it, and use"./dist/compiler-sfc.cjs.js"
for SSR.Another case can be
bcrypt-ts
The crypto module is different under node ('node:crypto') and browser (window.Crypto)