Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(client): avoid unnecessary parsing #1532

Closed
wants to merge 2 commits into from
Closed

perf(client): avoid unnecessary parsing #1532

wants to merge 2 commits into from

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8593720793

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.733%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/app/prepare/prepareRoutes.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 8548679901: 0.0%
Covered Lines: 685
Relevant Lines: 1683
💛 - Coveralls

@meteorlxy
Copy link
Member

Any reference? JSON.parse should have better performance than loading plain object

@Mister-Hope Mister-Hope closed this Apr 8, 2024
@Mister-Hope Mister-Hope deleted the client-perf branch April 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mister-Hope @coveralls @meteorlxy