Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown): fix linksPlugin parsing query and wrong absolute link #1537

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(markdown): fix linksPlugin parsing query and wrong absolute link #1537

wants to merge 9 commits into from

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 11, 2024 •
edited

  • Now queries are preserved instead of being removed
  • Absolute link is null when a link is relative and there is no markdown file info

This PR is based on #1521

@Mister-Hope Mister-Hope linked an issue Apr 11, 2024 that may be closed by this pull request
[Bug report] linkPlugin can not handle query #1536
Open
@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited

Pull Request Test Coverage Report for Build 8716692706

Details

  • 25 of 66 (37.88%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 41.202%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/client/src/router/resolveRoute.ts 0 1 0.0%
packages/client/src/router/resolveRoutePath.ts 0 2 0.0%
packages/client/src/components/RouteLink.ts 0 9 0.0%
packages/client/src/components/AutoLink.ts 0 29 0.0%
Totals Coverage Status
Change from base Build 8704379485: -0.6%
Covered Lines: 693
Relevant Lines: 1721
💛 - Coveralls

@Mister-Hope Mister-Hope mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] linkPlugin can not handle query
2 participants
@Mister-Hope @coveralls