Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support permalink: null in frontmatter to disable permalink #1547

Merged
merged 4 commits into from
Apr 21, 2024
Merged

feat(core): support permalink: null in frontmatter to disable permalink #1547

merged 4 commits into from
Apr 21, 2024

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 17, 2024 •
edited
Loading

Now users can set permalink: null to disable global permalinkPattern affect on certain pages.

This is more natural then setting permalink or permalinkPattern to page path in frontmatter.

@coveralls
Copy link

coveralls commented Apr 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8770375500

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.64%
Totals Coverage Status
Change from base Build 8716911468: 0.0%
Covered Lines: 680
Relevant Lines: 1678
💛 - Coveralls

meteorlxy
meteorlxy requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update unit tests

@meteorlxy meteorlxy merged commit becebb2 into main Apr 21, 2024
21 checks passed
@meteorlxy meteorlxy deleted the permalink branch April 21, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mister-Hope @coveralls @meteorlxy