Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler-webpack): enable css-modules for .module.css files (close #1557) #1560

Merged
merged 3 commits into from
May 17, 2024

Conversation

meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented May 17, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Documentation update
  • Other

Description

Closes #1557

BREAKING CHANGE: For webpack bundler, css-modules will be enabled for *.module.[ext] files. The previous *.[ext]?module usage is no longer supported.

@meteorlxy
Copy link
Member Author

@Mister-Hope - It seems that the current ?module usage is not working in webpack. Could you help to take a look?

@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9125869941

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 41.176%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bundler-webpack/src/config/handleModuleStyles.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 9112585623: 0.1%
Covered Lines: 688
Relevant Lines: 1710

💛 - Coveralls

@meteorlxy meteorlxy changed the title test(e2e): add test cases for css modules feat(bundler-webpack): enable css-modules for .module.css files May 17, 2024
@meteorlxy meteorlxy marked this pull request as ready for review May 17, 2024 09:19
@meteorlxy meteorlxy changed the title feat(bundler-webpack): enable css-modules for .module.css files feat(bundler-webpack): enable css-modules for .module.css files (close #1557) May 17, 2024
@meteorlxy meteorlxy merged commit 10378e1 into main May 17, 2024
30 checks passed
@meteorlxy meteorlxy deleted the meteorlxy/css-modules branch May 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] support *.module.ext for css modules
3 participants